-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add application layout components #1090
Conversation
This will fail CI until the following PRs land: |
The other PRs landed, and this one was rebased on main. There is a type confusion in the |
Fixed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "Default" view in storybook for AppNavigation, AppStatus, AppAside and others are empty. Should we change those?
Fixed! I merged these with stories that had content. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎉 This PR is included in version 0.59.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Done
Note: this PR requires the follow to land first:
Original PR and discussion: #1031.
A number of tests were performed using these components:
canonical/lxd-ui#768
canonical/identity-platform-admin-ui#309
canonical/maas-ui#5434
canonical/juju-dashboard#1752
canonical/rebac-admin#106
https://github.com/canonical/anbox-cloud-dashboard/pull/806
QA
Storybook
To see rendered examples of all react-components, run:
QA in your project
from
react-components
run:Install the resulting tarball in your project with:
QA steps
Note: the following PRs need to merge before this can be QAed:
Percy steps
Fixes
Fixes: #420.