Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add application layout components #1090

Merged
merged 5 commits into from
Jul 2, 2024
Merged

Conversation

huwshimi
Copy link
Collaborator

@huwshimi huwshimi commented May 17, 2024

Done

  • Add Vanilla application layout components.

Note: this PR requires the follow to land first:

Original PR and discussion: #1031.

A number of tests were performed using these components:

canonical/lxd-ui#768
canonical/identity-platform-admin-ui#309
canonical/maas-ui#5434
canonical/juju-dashboard#1752
canonical/rebac-admin#106
https://github.com/canonical/anbox-cloud-dashboard/pull/806

QA

Storybook

To see rendered examples of all react-components, run:

yarn start

QA in your project

from react-components run:

yarn build
npm pack

Install the resulting tarball in your project with:

yarn add <path-to-tarball>

QA steps

Note: the following PRs need to merge before this can be QAed:

Percy steps

  • New components expected.

Fixes

Fixes: #420.

@webteam-app
Copy link

@huwshimi
Copy link
Collaborator Author

@edlerd
Copy link
Contributor

edlerd commented Jun 28, 2024

The other PRs landed, and this one was rebased on main. There is a type confusion in the AppNavigation.stories.tsx file. I am not sure how to resolve or why it doesn't automatically pick up the right type with the icon prop. @huwshimi can you please have a look at this.

@huwshimi
Copy link
Collaborator Author

huwshimi commented Jul 1, 2024

The other PRs landed, and this one was rebased on main. There is a type confusion in the AppNavigation.stories.tsx file. I am not sure how to resolve or why it doesn't automatically pick up the right type with the icon prop. @huwshimi can you please have a look at this.

Fixed!

Copy link
Contributor

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Default" view in storybook for AppNavigation, AppStatus, AppAside and others are empty. Should we change those?

@huwshimi
Copy link
Collaborator Author

huwshimi commented Jul 2, 2024

The "Default" view in storybook for AppNavigation, AppStatus, AppAside and others are empty. Should we change those?

Fixed! I merged these with stories that had content.

Copy link
Contributor

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huwshimi huwshimi merged commit 6ca33ff into canonical:main Jul 2, 2024
13 of 14 checks passed
Copy link

github-actions bot commented Jul 2, 2024

🎉 This PR is included in version 0.59.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add components for application layout
3 participants