-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add application layout side navigation components #1089
Conversation
4220d87
to
2f503d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, two comments below, none of them are blocking.
One other aspect to think about: Will this be possible to extend for collapsible sections? See the video below for how it looks like. No need to implement this right away, just making sure with the introduced structure we don't make it too hard to extend as a next version of this.
Screencast.from.22.05.2024.10.55.05.webm
I suspect this should probably be a modification in Vanilla that we would then add to react-components. Right now this is supported in the side nav as you can pass any <SideNavigation<NavLinkProps>
dark
items={[
{
className: "sidenav-top-ul",
items: isAuthenticated
? [
...
{
icon: "connected",
label: "Networks",
onClick: softToggleMenu,
title: `Networks (${projectName})`,
to: `/ui/project/${projectName}/networks`,
},
<NavAccordion
baseUrl={`/ui/project/${projectName}/storage`}
title={`Storage (${projectName})`}
iconName="pods"
key="storage"
label="Storage"
onOpen={() => toggleAccordionNav("storage")}
open={openNavMenus.includes("storage")}
>
... |
🎉 This PR is included in version 0.58.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Done
QA
Storybook
To see rendered examples of all react-components, run:
QA in your project
from
react-components
run:Install the resulting tarball in your project with:
QA steps