Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-5827] Set all nodes to synchronous replicas #784

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Merge branch 'main' into dpe-5827-all-sync

2d5ab35
Select commit
Loading
Failed to load commit list.
Open

[DPE-5827] Set all nodes to synchronous replicas #784

Merge branch 'main' into dpe-5827-all-sync
2d5ab35
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 29, 2024 in 0s

75.39% (target 70.00%)

View this Pull Request on Codecov

75.39% (target 70.00%)

Details

Codecov Report

Attention: Patch coverage is 61.11111% with 7 lines in your changes missing coverage. Please review.

Project coverage is 75.39%. Comparing base (d8f8226) to head (2d5ab35).

Files with missing lines Patch % Lines
src/charm.py 25.00% 6 Missing ⚠️
src/patroni.py 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #784      +/-   ##
==========================================
- Coverage   75.48%   75.39%   -0.10%     
==========================================
  Files          12       12              
  Lines        3121     3138      +17     
  Branches      475      478       +3     
==========================================
+ Hits         2356     2366      +10     
- Misses        622      628       +6     
- Partials      143      144       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.