[DPE-5827] Set all nodes to synchronous replicas #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #784 +/- ##
==========================================
- Coverage 75.48% 75.39% -0.10%
==========================================
Files 12 12
Lines 3121 3138 +17
Branches 475 478 +3
==========================================
+ Hits 2356 2366 +10
- Misses 622 628 +6
- Partials 143 144 +1 ☔ View full report in Codecov by Sentry. |
dragomirp
commented
Nov 21, 2024
Comment on lines
+513
to
+528
| async def get_leader(model: Model, application_name: str) -> str: | ||
| """Get the standby leader name. | ||
|
|
||
| Args: | ||
| model: the model instance. | ||
| application_name: the name of the application to get the value for. | ||
|
|
||
| Returns: | ||
| the name of the standby leader. | ||
| """ | ||
| status = await model.get_status() | ||
| first_unit_ip = list(status["applications"][application_name]["units"].values())[0]["address"] | ||
| cluster = get_patroni_cluster(first_unit_ip) | ||
| for member in cluster["members"]: | ||
| if member["role"] == "leader": | ||
| return member["name"] |
There was a problem hiding this comment.
get_primary from the main helpers is not model aware.
dragomirp
commented
Nov 21, 2024
Comment on lines
-436
to
-438
| new_sync_standby = await get_sync_standby(first_model, DATABASE_APP_NAME) | ||
| logger.info(f"New sync-standby: {new_sync_standby}") | ||
| assert new_sync_standby != sync_standby, "Sync-standby is the same as before" |
There was a problem hiding this comment.
Sync standby will not change, since all the replicas are sync standbys.
dragomirp
requested review from
a team,
taurus-forever,
marceloneppel and
lucasgameiroborges
and removed request for
a team
lucasgameiroborges
approved these changes
Nov 22, 2024
marceloneppel
approved these changes
Nov 22, 2024
taurus-forever
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of canonical/postgresql-operator#672
Adds logic to update the number of synchronous standbys and sets all replicas to sync.