-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make layers with label prefix "pebble-" reserved #403
Conversation
Hi @benhoyt, I'm creating a draft PR, I'm not sure if this is the right way to implement it: In order to use Then I found out But I think in Go it is generally recommended to avoid relying on error messages and it's better to handle errors based on types, right? So in my draft I created another type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good -- just some minor changes requested.
Co-authored-by: Ben Hoyt <[email protected]>
Making layers with label "pebble-*" reserved for pebble use only.
Closes #220.
Test: