Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make layer labels starting with the "pebble-" prefix reserved #220

Closed
rebornplusplus opened this issue May 16, 2023 · 3 comments · Fixed by #403
Closed

Make layer labels starting with the "pebble-" prefix reserved #220

rebornplusplus opened this issue May 16, 2023 · 3 comments · Fixed by #403
Assignees
Labels
Simple Nice for a quick look on a minute or two

Comments

@rebornplusplus
Copy link
Member

Following the discussions from #191 (comment), consider making any layer labels starting with the pebble- prefix reserved.

@barrettj12
Copy link
Contributor

@aliamerj easy one for you to start on

@aliamerj
Copy link

aliamerj commented Sep 9, 2023

Hello, i am working on this issue , i just need some clarification

  • Could you please provide more details on what "reserving" labels with "pebble-" prefix entails? Are we preventing users from creating such labels? Or is it about some internal logic?

  • Scope: Is the reservation of "pebble-" prefixed labels only applicable to certain parts of the Pebble system, or is it universally across all features?

  • Case Sensitivity: Is the "pebble-" prefix case-sensitive? Should I treat "Pebble-" the same as "pebble-" when implementing this feature?

@barrettj12
Copy link
Contributor

Hi @aliamerj, reserving the label means the user shouldn't be able to create a layer with that label. i.e. label names of the form nnn-pebble-* are disallowed.

There is currently code in the plan package which checks for e.g. reserved service names - just add a check for reserved labels, and a corresponding unit test.

I think just handle the lowercase version pebble-, don't worry about other cases.

@benhoyt benhoyt added Simple Nice for a quick look on a minute or two 24.04 labels Mar 13, 2024
benhoyt pushed a commit that referenced this issue Apr 8, 2024
Making layers with label "pebble-*" reserved for pebble use only.

Closes #220.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Simple Nice for a quick look on a minute or two
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants