Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove deprecated functions now that we're on Go 1.16+ #375

Merged
merged 5 commits into from
Mar 7, 2024
Merged

chore: remove deprecated functions now that we're on Go 1.16+ #375

merged 5 commits into from
Mar 7, 2024

Commits on Feb 29, 2024

  1. Replace the now-deprecated ioutil with the respective os and io funcs 

    The only instance that required an actual change was the use of
ioutil.ReadDir in api_files.go, which I changed to os.ReadDir, but that
now returns a []DirEntry, so minor changes were required. All the other
changes were straight search-n-replaces.
    @benhoyt
    benhoyt committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    0d85bea View commit details
    Browse the repository at this point in the history

  2. Replace deprecated x/crypto/ssh/terminal with x/term replacement

    @benhoyt
    benhoyt committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    b7e0217 View commit details
    Browse the repository at this point in the history

  3. Avoid use of rec.HeaderMap

    @benhoyt
    benhoyt committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    6b3a409 View commit details
    Browse the repository at this point in the history

  4. Use signal.NotifyContext (in Go 1.16) instead of rolling our own

    @benhoyt
    benhoyt committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    409b145 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Use ResponseRecorder.Result().Header instead of Header() directly 

    This is the correct usage after a handler completes, see:
https://pkg.go.dev/net/http/httptest#ResponseRecorder.Header
    @benhoyt
    benhoyt committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    979d231 View commit details
    Browse the repository at this point in the history