chore: remove deprecated functions now that we're on Go 1.16+ #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only instance that required an actual change was the use of ioutil.ReadDir in api_files.go, which I changed to os.ReadDir, but that now returns a []DirEntry, so minor changes were required. All the other changes were straight search-n-replaces.
benhoyt
changed the title
flotter
reviewed
Mar 7, 2024
flotter
approved these changes
Mar 7, 2024
This is the correct usage after a handler completes, see: https://pkg.go.dev/net/http/httptest#ResponseRecorder.Header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces most deprecated functions with modern equivalents, now that we're using Go 1.16+:
ioutil.Foowith respective functions inioandos(this is the vast majority of the changed lines).golang.org/x/crypto/ssh/terminalpackage withgolang.org/x/term.ResponseRecorder.HeaderMapand.Header()signal.NotifyContextnow that it exists, instead of rolling our own.Look at the commits individually if you want to see these separated out.
For reference, I found these usages with simple search, as well as the following staticcheck command (note that there are still some left that I didn't think worth updating):