fix: Comment out firing alert rule #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orfeas-k
changed the title
orfeas-k
force-pushed
the
kf-6343-fix-alert
branch
from
0eea69f
to
f02b58d
Compare
orfeas-k
changed the title
NohaIhab
reviewed
Nov 5, 2024
There was a problem hiding this comment.
Hi @orfeas-k , I agree to the suggested fix to remove the rule temporarily, but I have a suggestion: to comment out the code with a link to the issue instead of deleting it entirely. This way it's easier for us to keep track and revert once the upstream issue is resolved. wdyt?
orfeas-k
changed the title
NohaIhab
approved these changes
Nov 6, 2024
orfeas-k
added a commit
that referenced
this pull request
Nov 6, 2024
This comments out an alert rule that's always `Firing` due to kubeflow/notebooks#62 Ref #409
orfeas-k
added a commit
that referenced
this pull request
Nov 7, 2024
backport(fix): Comment out firing alert rule from #412
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comments out an alert rule that's always
Firingdue to kubeflow/notebooks#62. We will bring this back once the issue is fixed upstream.Ref #409