Merge pull request #414 from canonical/kf-6343-fix-alert-backport

backport(fix): Comment out firing alert rule from #412

charms/jupyter-controller/src/prometheus_alert_rules/model_errors.archived_rule

@@ -0,0 +1,12 @@
+# Uncomment the alert below and modify the file's extension to be `.rule`
+# once https://github.com/canonical/notebook-operators/issues/409 is fixed
+# alert: JupyterControllerRuntimeReconciliationErrorsExceedThreshold
+# expr: rate(controller_runtime_reconcile_errors_total[5m]) > 0
+# for: 0m
+# labels:
+#   severity: critical
+# annotations:
+#   summary: Total number of reconciliation errors per controller
+#   description: >
+#     Total number of reconciliation errors per controller
+#     LABELS = {{ $labels }}

charms/jupyter-controller/tests/unit/test_operator.py

@@ -112,9 +112,11 @@ def test_prometheus_data_set(self, harness: Harness, mocker):
             # there 2 alert rules in host_resources.rules
             for rule in file_alert["groups"][0]["rules"]:
                 test_alerts.append(rule["alert"])
-        with open("src/prometheus_alert_rules/model_errors.rule") as f:
-            file_alert = yaml.safe_load(f.read())
-            test_alerts.append(file_alert["alert"])
+        # Uncomment once https://github.com/canonical/notebook-operators/issues/409
+        # is fixed.
+        # with open("src/prometheus_alert_rules/model_errors.rule") as f:
+        #     file_alert = yaml.safe_load(f.read())
+        #     test_alerts.append(file_alert["alert"])
         with open("src/prometheus_alert_rules/KubeflowJupyterControllerServices.rules") as f:
             file_alert = yaml.safe_load(f.read())
             # there 2 alert rules in host_resources.rules