Move poetry export inside the charm build #301
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This demonstrates using `poetry export` inside the build of the charm, allowing the user to `git clone` and then `charmcraft pack`. It also: - Uses the dump plugin to add extra primed files - Adds an explicit requirements file (see: canonical/charmcraft#1389)
|
implemented in #319 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This demonstrates using
poetry exportinside the build of the charm, allowing the user togit cloneand thencharmcraft pack.It also:
NOTE: this requires canonical/charmcraft#1808 before charmcraft will work.
Issue
Solution