fix(charm-plugin): remove existence checks for reqs #1808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requirements files might not exist yet when the charm plugin is instantiated, so don't check for their existence in the plugin.
lengau
force-pushed
the
work/1389/model-looser
branch
from
2099f9e to
f80f5d1
Compare
This makes strict dependencies only fail during the charm builder step if extra binary dependencies exist, but allows dynamically created requirements.txt files.
mr-cal
approved these changes
Aug 13, 2024
tigarmo
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements files might not exist yet when the charm plugin is instantiated, so don't check for their existence in the plugin.