Avoid any actions when a unit is offline and allow mysql GR to recover #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #334 +/- ##
==========================================
+ Coverage 63.96% 64.01% +0.05%
==========================================
Files 16 16
Lines 2997 2993 -4
Branches 390 389 -1
==========================================
- Hits 1917 1916 -1
+ Misses 956 955 -1
+ Partials 124 122 -2
|
shayancanonical
requested review from
delgod,
paulomach,
carlcsaposs-canonical and
taurus-forever
carlcsaposs-canonical
previously approved these changes
Oct 5, 2023
shayancanonical
dismissed stale reviews from paulomach and carlcsaposs-canonical
via
58c3adb
paulomach
approved these changes
Oct 5, 2023
carlcsaposs-canonical
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The SST test fails because we are taking an action when a unit is offline (we are currently trying to rejoin the instance to the cluster).
Solution
Do nothing, as MySQL Group Replication has logic around rejoining an offline instance.