-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPE-2651] Juju3 pipelines / Testing secrets #333
Conversation
34ec048
to
de5f403
Compare
Codecov Report
@@ Coverage Diff @@
## main #333 +/- ##
==========================================
+ Coverage 64.50% 65.46% +0.96%
==========================================
Files 17 17
Lines 3113 3113
Branches 413 413
==========================================
+ Hits 2008 2038 +30
+ Misses 979 946 -33
- Partials 126 129 +3
|
466af7c
to
fa03650
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks amazing!
e08f0fd
to
d9469b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're planning to support multiple juju versions long-term, I think we might want to rework the fixture so that it's only for integration tests and unit tests for all juju versions run at the same time
But if we only need to support juju 2+3 for a short time this looks good
Also I think the skip vs deselect for tests might be a bit confusing with the UX that we're using to group integration tests, but since we're not heavily using groups we probably won't encounter that often for now
04028c8
to
d5260ad
Compare
2b260f4
9c5434d
to
6aaaeb0
Compare
9fe03fa
to
88f7a31
Compare
a1e625d
349ea97
to
a1e625d
Compare
a1e625d
to
167f2a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
excellent, thank you
Issue
JujuVersion.has_secrets
have to be correctly patched so that secrets-related code would be invokedSolution
Pytest fixtures ensuring the usage to
JujuVersion.has_secrets
(instead of its default behavior returningFalse
all way through)NOTE: The 3 pipeline failures are unrelated to secrets. They will be addressed in upcoming PRs as below.
This PR will be merged AFTER those.