Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix subnets hightlight #1245

Merged
merged 2 commits into from
Jun 12, 2020
Merged

Fix subnets hightlight #1245

merged 2 commits into from
Jun 12, 2020

Conversation

huwshimi
Copy link
Contributor

Done

  • Highlight the subnets nav item.

QA

  • Click on the subnets item in the main nav, it should stay highlighted.
  • Click on other items, they should still highlight.

huwshimi
huwshimi commented Jun 12, 2020
View reviewed changes
shared/src/components/Header/Header.js
@@ -65,7 +65,7 @@ export const Header = ({
window.ga("set", "dimension2", uuid);

const sendPageview = () => {
const path = window.location.pathname + window.location.hash;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use /l/ instead of /#/ so I've removed that as part of the url.

squidsoup
squidsoup approved these changes Jun 12, 2020
View reviewed changes
Copy link
Contributor

@squidsoup squidsoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly, thanks!

@Caleb-Ellis Caleb-Ellis merged commit 9899e1e into canonical:master Jun 12, 2020
Caleb-Ellis pushed a commit to Caleb-Ellis/maas-ui that referenced this pull request Jun 12, 2020
@huwshimi
Fix highlighting the subnets nav item. (canonical#1245)
ca113f2
@Caleb-Ellis Caleb-Ellis mentioned this pull request Jun 12, 2020
Merged
Caleb-Ellis pushed a commit that referenced this pull request Jun 12, 2020
@huwshimi
Release v1.3.2 (#1246)
c188f58 
* Revert Images page to checkboxes, but add warning for unsupported arches. (#1243)

* Fix redirects that land at old legacy # urls. (#1244)

* Fix highlighting the subnets nav item. (#1245)

* Release v1.3.2

Co-authored-by: huwshimi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squidsoup squidsoup squidsoup approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huwshimi @squidsoup @Caleb-Ellis