Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert Images page to checkboxes, but add warning for unsupported arches. #1243

Merged
merged 1 commit into from
Jun 12, 2020
Merged

Revert Images page to checkboxes, but add warning for unsupported arches. #1243

merged 1 commit into from
Jun 12, 2020

Conversation

Caleb-Ellis
Copy link
Contributor

@Caleb-Ellis Caleb-Ellis commented Jun 12, 2020 •
edited
Loading

Done

  • Reverted images page to use checkboxes instead of radio buttons, but added some functionality for highlighting unsupported architectures.

QA

  • Go to the images page and check that the radio buttons are now checkboxes.
  • Select 20.04 LTS and check that the i386 checkbox is disabled.
  • Select more than one release and check that the i386 checkbox is enabled with a warning.
  • Select i386 and check that the table of images does not include 20.04/i386
  • Leave i386 checked, and uncheck all non-20.04 releases and see that the i386 checkbox becomes disabled and unchecked automatically.
  • Uncheck 20.04 and check two other releases and see that the i386 checkbox is enabled with no warning
  • Check that you can still download/remove images successfully.

Fixes

Fixes #1241

Screeshots

Multiple releases selected, including 20.04

0 0 0 0_8400_MAAS_l_images (3)

Multiple releases selected, not including 20.04

0 0 0 0_8400_MAAS_l_images (5)

Just 20.04 selected

0 0 0 0_8400_MAAS_l_images (4)

squidsoup
squidsoup approved these changes Jun 12, 2020
View reviewed changes
Copy link
Contributor

@squidsoup squidsoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, sorry for the last minute revert!

@Caleb-Ellis Caleb-Ellis merged commit 45b1956 into canonical:master Jun 12, 2020
@Caleb-Ellis Caleb-Ellis deleted the revert-images-ux branch June 12, 2020 03:12
Caleb-Ellis pushed a commit to Caleb-Ellis/maas-ui that referenced this pull request Jun 12, 2020
Revert Images page to checkboxes, but add warning for unsupported arc…
5c305b5 
…hes. (canonical#1243)
@Caleb-Ellis Caleb-Ellis mentioned this pull request Jun 12, 2020
Merged
Caleb-Ellis pushed a commit that referenced this pull request Jun 12, 2020
@huwshimi
Release v1.3.2 (#1246)
c188f58 
* Revert Images page to checkboxes, but add warning for unsupported arches. (#1243)

* Fix redirects that land at old legacy # urls. (#1244)

* Fix highlighting the subnets nav item. (#1245)

* Release v1.3.2

Co-authored-by: huwshimi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squidsoup squidsoup squidsoup approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

20.04 LTS does not support i368
2 participants
@Caleb-Ellis @squidsoup