Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unify tox environment for dependency update #59

Open
beliaev-maksim opened this issue Jun 7, 2023 · 6 comments
Open

unify tox environment for dependency update #59

beliaev-maksim opened this issue Jun 7, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@beliaev-maksim
Copy link
Member

beliaev-maksim commented Jun 7, 2023 •
edited
Loading

Currently we have different env ([testenv:update-requirements]) for reqs.txt updates in tox

we need a canon run to unify them across all repos. Things to consider:

  1. same resolver everywhere
  2. consider -U option (or add separate env)
  3. fix (or clean up afterwards) all the comment lines. It should be aligned with renovate style to avoid noise in PRs (example PR)

image
@kimwnasptd kimwnasptd added the enhancement New feature or request label Jun 13, 2023
@ca-scribner
Copy link
Contributor

@beliaev-maksim did your most recent work solve this? I can't remember if you pushed it to just one repo, or all repos

@beliaev-maksim
Copy link
Member Author

@ca-scribner no, I still wait for review in argo

@beliaev-maksim
Copy link
Member Author

need to run the change proposed in canonical/argo-operators#100 for all the repos

@orfeas-k
Copy link
Contributor

orfeas-k commented Aug 9, 2023

Do these PRs solve this issue? If not, is there a list of repos, we need to send PRs for?

@beliaev-maksim
Copy link
Member Author

@orfeas-k they do. Was it applied to all repos?

@orfeas-k
Copy link
Contributor

orfeas-k commented Aug 21, 2023 •
edited
Loading

Made this list of all MLOps repos (excluding ROCKs) and I 'll try to go through it the next days and note which ones need a PR for this issue to close.

@orfeas-k orfeas-k mentioned this issue Sep 14, 2023
Merged
orfeas-k added a commit to canonical/kubeflow-volumes-operator that referenced this issue Sep 14, 2023
@orfeas-k
update tox.ini's update-requirements (#113)
1499c11 
Ref canonical/kubeflow-ci#59
This was referenced Sep 29, 2023
Merged
Merged
orfeas-k added a commit to canonical/seldon-core-operator that referenced this issue Sep 29, 2023
@orfeas-k
update tox.ini's update-requirements (#215)
b8d45d8 
Updates tox.ini's update-requirements as described in canonical/argo-operators#100
Ref canonical/kubeflow-ci#59
orfeas-k added a commit to canonical/admission-webhook-operator that referenced this issue Sep 29, 2023
@orfeas-k
update tox.ini's update-requirements (#115)
cbc7cc2 
Updates tox.ini's update-requirements as described in canonical/argo-operators#100
Ref canonical/kubeflow-ci#59
orfeas-k added a commit to canonical/envoy-operator that referenced this issue Oct 16, 2023
@orfeas-k
update tox.ini's update-requirements
a78531a 
Updates tox.ini's `update-requirements` as described in
canonical/argo-operators#100.

Ref canonical/kubeflow-ci#59
orfeas-k added a commit to canonical/envoy-operator that referenced this issue Oct 19, 2023
@orfeas-k
Configure envoy-operator for CKF 1.8 (#56)
a7ae213 
* update tox.ini's update-requirements
* requirements*.txt: Update with tox command
* Configure charm according to upstream file
`third_party/metadata_envoy/envoy.yaml` in pipelines repo.
* tests(unit): Update expected config
* tests(integration): Trust charms and configure relation names
* ci: Update integrate workflow environment
* tests(integration): Update channel and assertions

Ref canonical/kubeflow-ci#59
NohaIhab added a commit to canonical/seldon-core-operator that referenced this issue Oct 19, 2023
@NohaIhab
ci: update juju to 3.1 and microk8s to 1.25
50ff928 
update tox.ini's update-requirements (#215)

Updates tox.ini's update-requirements as described in canonical/argo-operators#100
Ref canonical/kubeflow-ci#59

doc link (#214)

tests(integration): Apply seldondeployments in namespace `default` (#220)

* tests(integration): Refactor

Refactor integration tests after hitting issue #218. This is a
workaround for the issue. At the same time, it is needed to revert those
back since up until now, integration tests were applying
seldondeployments to the namespace created by Juju. In production, this
would be `kubeflow` and we would never apply something there.

* tests(integration): Rename DEFAULT_NAMESPACE to WORKLOADS_NAMESPACE

Contributing (#219)

Co-authored-by: Orfeas Kourkakis <[email protected]>

chore: bump seldon charm 1.15 -> 1.17.1 for CKF release 1.8 (#216)

* bump seldon-core-operator 1.15.0 -> 1.17.1 for CKF 1.8
* manifests: Update CRD according to upstream manifests
* manifests: Update manifests roles names
* Use upstream images 1.17.1 for seldon servers
* tests(unit): Modify expected pebble plan
* tests(integration): Update expected huggingface output
* tests(integration): Update expected mlserver-mlflow output
* contributing.md: Add update manifests instructions
* gitignore: Ignore venv directory

reqs: refresh requirements-integration.txt
This was referenced Dec 3, 2024
Open
Merged
Merged
Merged
Merged
Merged
Merged
Merged
orfeas-k added a commit to canonical/resource-dispatcher that referenced this issue Dec 4, 2024
@orfeas-k
fix: Update tox update-requirements environment (#75)
07e7712 
Ref canonical/bundle-kubeflow#1177
Ref canonical/kubeflow-ci#59
orfeas-k added a commit to canonical/oidc-gatekeeper-operator that referenced this issue Dec 4, 2024
@orfeas-k
fix: Update tox update-requirements environment (#185)
d649e31 
Ref canonical/bundle-kubeflow#1177
Ref canonical/kubeflow-ci#59
orfeas-k added a commit to canonical/mlmd-operator that referenced this issue Dec 4, 2024
@orfeas-k
fix: Update tox update-requirements environment (#108)
e2370ab 
Ref canonical/bundle-kubeflow#1177
Ref canonical/kubeflow-ci#59
orfeas-k added a commit to canonical/metacontroller-operator that referenced this issue Dec 4, 2024
@orfeas-k
fix: Update tox update-requirements environment (#142)
cdaee8d 
Ref canonical/bundle-kubeflow#1177
Ref canonical/kubeflow-ci#59
orfeas-k added a commit to canonical/kubeflow-roles-operator that referenced this issue Dec 4, 2024
@orfeas-k
fix: Update tox update-requirements environment (#104)
bd0fdd9 
Ref canonical/bundle-kubeflow#1177
Ref canonical/kubeflow-ci#59
orfeas-k added a commit to canonical/mlflow-operator that referenced this issue Dec 4, 2024
@orfeas-k
fix: Update tox update-requirements environment (#295)
ba40a2a 
Ref canonical/bundle-kubeflow#1177
Ref canonical/kubeflow-ci#59
orfeas-k added a commit to canonical/katib-operators that referenced this issue Dec 4, 2024
@orfeas-k
fix: Update tox update-requirements environment (#251)
13ca74a 
Ref canonical/bundle-kubeflow#1177
Ref canonical/kubeflow-ci#59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kimwnasptd @orfeas-k @ca-scribner @beliaev-maksim