Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix charm dependecies #479

Closed
wants to merge 2 commits into from
Closed

Fix charm dependecies #479

wants to merge 2 commits into from

Conversation

rgildein
Copy link
Contributor

@rgildein rgildein commented Jul 22, 2024 •
edited
Loading

Add cos along with grafana_dashboard and prometheus_scrape, since this is related with #477.

Part of canonical/bundle-kubeflow#989

@rgildein
Fix charm dependecies
523e051 
Add cos along with grafana_dashboard and prometheus_scrape, since
this is related with #477.
@rgildein rgildein added bug Something isn't working enhancement New feature or request labels Jul 22, 2024
@rgildein rgildein self-assigned this Jul 22, 2024
@rgildein rgildein marked this pull request as ready for review July 22, 2024 20:34
@rgildein rgildein requested a review from a team as a code owner July 22, 2024 20:34
DnPlas
DnPlas requested changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@DnPlas DnPlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not merge, as we might need to make a different change. Check canonical/charmcraft#1135 (comment) for more context.

@rgildein
Copy link
Contributor Author

Please do not merge, as we might need to make a different change. Check canonical/charmcraft#1135 (comment) for more context.

Since I bump cosl to newer verions cosl==0.0.14, the PYDEPS tried only installed the same version. But I agree that we may need to use charm-strict-dependencies: true.

misohu
misohu reviewed Jul 23, 2024
View reviewed changes
Copy link
Member

@misohu misohu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we split it into two PRS one for the CI upgrade and one for adding the libs. I understand we want to test it but we can always refer this previous run and split it. Also I miss the information about how did we update the requirements in description.

@rgildein
Copy link
Contributor Author

Closing since @misohu is doing part of it in #476 and second part of bringing cosl to isto-gateway will be done in #477.

@rgildein rgildein closed this Jul 24, 2024
@rgildein rgildein deleted the chore/KF-6040/build-fix branch July 24, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misohu misohu misohu left review comments

@DnPlas DnPlas DnPlas requested changes

Assignees

@rgildein rgildein

Labels
bug Something isn't working enhancement New feature or request Libraries: OK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rgildein @misohu @DnPlas