Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix istio CI #476

Merged
merged 9 commits into from
Jul 24, 2024
Merged

Fix istio CI #476

merged 9 commits into from
Jul 24, 2024

Conversation

misohu
Copy link
Member

@misohu misohu commented Jul 19, 2024

Fixes:

@misohu misohu changed the title Use charmcraft edge Fix istio CI Jul 24, 2024
Copy link
Contributor

@DnPlas DnPlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @misohu ! Two tiny comments, other than that lgtm!

charms/istio-gateway/charmcraft.yaml Outdated Show resolved Hide resolved
charms/istio-gateway/requirements-fmt.txt Outdated Show resolved Hide resolved
@rgildein rgildein mentioned this pull request Jul 24, 2024
Copy link
Contributor

@DnPlas DnPlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @misohu !

@misohu misohu merged commit ed1526b into main Jul 24, 2024
19 checks passed
@misohu misohu deleted the KF-5656-fix-charmcraft-setuptools branch July 24, 2024 14:50
misohu added a commit that referenced this pull request Jul 25, 2024
* jinja update
* Remove tls libs from charmcraft in istio-pilot and move them to requirements
misohu added a commit that referenced this pull request Jul 25, 2024
* jinja update
* Remove tls libs from charmcraft in istio-pilot and move them to requirements
misohu added a commit that referenced this pull request Jul 25, 2024
* jinja update
* Remove tls libs from charmcraft in istio-pilot and move them to requirements
misohu added a commit that referenced this pull request Jul 25, 2024
* jinja update
* Remove tls libs from charmcraft in istio-pilot and move them to requirements
misohu added a commit that referenced this pull request Jul 25, 2024
* jinja update
* Remove tls libs from charmcraft in istio-pilot and move them to requirements
misohu added a commit that referenced this pull request Jul 25, 2024
* jinja update
* Remove tls libs from charmcraft in istio-pilot and move them to requirements
misohu added a commit that referenced this pull request Jul 25, 2024
* jinja update
* Remove tls libs from charmcraft in istio-pilot and move them to requirements
misohu added a commit that referenced this pull request Jul 25, 2024
* jinja update
* Remove tls libs from charmcraft in istio-pilot and move them to requirements
misohu added a commit that referenced this pull request Jul 25, 2024
* jinja update
* Remove tls libs from charmcraft in istio-pilot and move them to requirements
misohu added a commit that referenced this pull request Jul 25, 2024
* jinja update
* Remove tls libs from charmcraft in istio-pilot and move them to requirements
misohu added a commit that referenced this pull request Jul 25, 2024
* jinja update
* Remove tls libs from charmcraft in istio-pilot and move them to requirements
misohu added a commit that referenced this pull request Jul 25, 2024
* jinja update
* Remove tls libs from charmcraft in istio-pilot and move them to requirements
misohu added a commit that referenced this pull request Jul 25, 2024
* jinja update
* Remove tls libs from charmcraft in istio-pilot and move them to requirements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants