Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set meshConfig.accessLogFile configuration for exposing logs #371

Merged
merged 2 commits into from
Feb 4, 2024
Merged

feat: set meshConfig.accessLogFile configuration for exposing logs #371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26fbfec
feat: set meshConfig.accessLogFile configuration for exposing logs
DnPlas Jan 25, 2024
83db34d
skip: fix unit tests
DnPlas Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions charms/istio-pilot/src/charm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,7 @@ def _istioctl_extra_flags(self):

# Extra flags to pass to the istioctl install command
# These flags will configure the container images used by the control plane
# As well as set the access log files for help during debugging
extra_flags = [
"--set",
f"values.pilot.image={pilot_image}",
Expand All @@ -204,6 +205,8 @@ def _istioctl_extra_flags(self):
f"values.global.proxy.image={global_proxy_image}",
"--set",
f"values.global.proxy_init.image={global_proxy_init_image}",
"--set",
"meshConfig.accessLogFile=/dev/stdout",
]

# The following are a set of flags that configure the CNI behaviour
Expand Down
2 changes: 2 additions & 0 deletions charms/istio-pilot/tests/unit/test_charm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1323,6 +1323,8 @@ def test_upgrade_successful(
"values.global.proxy.image=proxyv2",
"--set",
"values.global.proxy_init.image=proxyv2",
"--set",
"meshConfig.accessLogFile=/dev/stdout",
],
)
mocked_istioctl.upgrade.assert_called_with()
Expand Down
Loading