Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set meshConfig.accessLogFile configuration for exposing logs #371

Merged
merged 2 commits into from
Feb 4, 2024

Conversation

DnPlas
Copy link
Contributor

@DnPlas DnPlas commented Jan 25, 2024

This setting allow users to access debug logs.

Fixes #370

Manual testing

As described in #370's description.

This setting allow users to access debug logs.

Fixes #370
@DnPlas DnPlas requested a review from a team as a code owner January 25, 2024 01:29
@orfeas-k
Copy link
Contributor

orfeas-k commented Feb 1, 2024

Is this change expected to take place if I juju refresh an older revision of istio charms?

Copy link
Contributor

@orfeas-k orfeas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I tried in a deployment with older istio and worked there too.

@DnPlas
Copy link
Contributor Author

DnPlas commented Feb 4, 2024

Is this change expected to take place if I juju refresh an older revision of istio charms?

Yes, the istioctl upgrade command should catch the extra flags, so any version before this change should automatically have it once the istio-pilot charm is updated with juju refresh.

@DnPlas DnPlas merged commit 4b86064 into main Feb 4, 2024
17 checks passed
@DnPlas DnPlas deleted the KF-5209-enable-envoy-access-logs branch February 4, 2024 00:19
kimwnasptd pushed a commit that referenced this pull request Jul 4, 2024
)

* feat: set meshConfig.accessLogFile configuration for exposing logs

This setting allow users to access debug logs.

Fixes #370
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Envoy access logs are not exposed by default
2 participants