This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
Add tests for snap config options #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `TestAppConfig()` test * Separate tests * Remove redundant subtest, move unset to cleanup - remove redundant subtest - move unset to cleanup - add comment for existing issue - improve words * Update device-rest's config_test * Do `snap set`, then `snap start`
#49) * Add `TestAppConfig()` test * Separate tests * Remove redundant subtest, move unset to cleanup - remove redundant subtest - move unset to cleanup - add comment for existing issue - improve words * Update device-rest's config_test * Do `snap set`, then `snap start` * Setting FULL_CONFIG_TEST make skipping of config subtests optional * Move config testing into util functions * Use boolean for `FullConfigTest`, add message for `t.Skip()` * Update `if else` and README format * Add `config-enabled` for new version hooks new version hooks: canonical/edgex-snap-hooks#41
This was referenced Apr 25, 2022
Merged
This was referenced Apr 25, 2022
Merged
* Add config testing for device-modbus * Add snap channel for ci testing
Merged
5 tasks
This was referenced Apr 25, 2022
* Add config testing for device-snmp * Add dev channel to ci workflow
* Update edgex-go's config test * Restart device-virtual * Trigger GitHub action with branch config * start/stop service instead of snap * start/stop platformSnap outside of utils * pass Github action channel to PLATFORM_CHANNEL * start platformSnap * change github action branch back to main * only start/stop affected service, rename `snapAppName` to `deviceVirtualService` * use branch config for github action testing * Revert trigger to main
5 tasks
farshidtz
commented
Apr 27, 2022
- remove obsolete comments - add comments for env vars - constant for service wait timeouts in config - error handling for boolean parsing
|
@MonicaisHer great job on adding these tests in time. Everything is now passing and this looks ready to merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds config tests for several snaps. To verify the test results, refer to the PR checks below.
PRs (checked means reviewed and ready to merge):
The snaps are uploaded to branches to allow this testing until the upstream PRs have been merged:
The channel overrides in the CI workflow can be removed once the PRs are merged and the nightly builds complete.