This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
Fix options migration, implement proxy options #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farshidtz
changed the title
* Export log init to re-initialize debug mode in external tests
farshidtz
force-pushed
the
options-migration-fix
branch
from
80677de to
349c72a
Compare
5 tasks
5 tasks
farshidtz
pushed a commit
to canonical/edgex-snap-testing
that referenced
this pull request
Apr 22, 2022
#49) * Add `TestAppConfig()` test * Separate tests * Remove redundant subtest, move unset to cleanup - remove redundant subtest - move unset to cleanup - add comment for existing issue - improve words * Update device-rest's config_test * Do `snap set`, then `snap start` * Setting FULL_CONFIG_TEST make skipping of config subtests optional * Move config testing into util functions * Use boolean for `FullConfigTest`, add message for `t.Skip()` * Update `if else` and README format * Add `config-enabled` for new version hooks new version hooks: canonical/edgex-snap-hooks#41
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for #38.
Moved proxy-related code to the options package.
Added proxy options processing for TLS:
Added proxy options processing for user:
For usability purposes, the username, userid, algorithm of the single user have been hardcoded to admin, 1, ES256. This should be sufficient since we don't allow setting multiple users using snap options. The algorithm is set to ES256 rather than RS256, because it is more secure.
To avoid mixed option issues, the new namespace is now enabled after opting-in by setting
config-enabled=true.Testing instructions
Add the following to go.mod: