Add config tests for device-rfid-llrp (#57)

canonical · Apr 25, 2022 · 018ca2b · 018ca2b
1 parent a481b76
commit 018ca2b
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 19 deletions.
diff --git a/test/suites/device-rfid-llrp/config_test.go b/test/suites/device-rfid-llrp/config_test.go
@@ -7,25 +7,18 @@ import (
 
 // Deprecated
 func TestEnvConfig(t *testing.T) {
+	utils.SetEnvConfig(t, deviceRfidLlrpSnap, deviceRfidLlrpService, defaultServicePort)
+}
 
-	t.Run("change service port", func(t *testing.T) {
-		t.Cleanup(func() {
-			utils.SnapStop(t, deviceRfidLlrpService)
-			utils.SnapUnset(t, deviceRfidLlrpSnap, "env.service.port")
-		})
-
-		const newPort = "56789"
-
-		// make sure the port is available before using it
-		utils.RequirePortAvailable(t, newPort)
+func TestAppConfig(t *testing.T) {
+	utils.SetAppConfig(t, deviceRfidLlrpSnap, deviceRfidLlrpService, deviceRfidApp, defaultServicePort)
+}
 
-		utils.SnapStop(t, deviceRfidLlrpSnap)
-		utils.SnapSet(t, deviceRfidLlrpSnap, "env.service.port", newPort)
-		utils.SnapStart(t, deviceRfidLlrpSnap)
-		utils.WaitServiceOnline(t, 60, newPort)
-	})
+func TestGlobalConfig(t *testing.T) {
+	// start clean
+	utils.SetGlobalConfig(t, deviceRfidLlrpSnap, deviceRfidLlrpService, defaultServicePort)
 }
 
-func TestAppConfig(t *testing.T) {
-	t.Skip("TODO")
+func TestMixedConfig(t *testing.T) {
+	utils.SetMixedConfig(t, deviceRfidLlrpSnap, deviceRfidLlrpService, deviceRfidApp, defaultServicePort)
 }
diff --git a/test/suites/device-rfid-llrp/main_test.go b/test/suites/device-rfid-llrp/main_test.go
@@ -8,8 +8,11 @@ import (
 	"time"
 )
 
-const deviceRfidLlrpSnap = "edgex-device-rfid-llrp"
-const deviceRfidLlrpService = "edgex-device-rfid-llrp.device-rfid-llrp"
+const (
+	deviceRfidLlrpSnap    = "edgex-device-rfid-llrp"
+	deviceRfidApp         = "device-rfid-llrp"
+	deviceRfidLlrpService = "edgex-device-rfid-llrp." + deviceRfidApp
+)
 
 var start = time.Now()