Add config testing for device-modbus (#55)

* Add config testing for device-modbus * Add snap channel for ci testing
canonical · Apr 25, 2022 · a481b76 · a481b76
1 parent 5d1ce60
commit a481b76
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 6 deletions.
diff --git a/.github/workflows/snap-testing.yml b/.github/workflows/snap-testing.yml
@@ -32,6 +32,7 @@ jobs:
           - name: device-snmp
 
           - name: device-modbus
+            channel: edge/pr-336
 
           - name: edgexfoundry
 

diff --git a/test/suites/device-modbus/config_test.go b/test/suites/device-modbus/config_test.go
@@ -7,11 +7,18 @@ import (
 
 // Deprecated
 func TestEnvConfig(t *testing.T) {
-	t.Run("change service port", func(t *testing.T) {
-		utils.TestEnvChangeServicePort(t, deviceModbusSnap, defaultServicePort)
-	})
+	utils.SetEnvConfig(t, deviceModbusSnap, deviceModbusService, defaultServicePort)
 }
 
 func TestAppConfig(t *testing.T) {
-	t.Skip("TODO")
+	utils.SetAppConfig(t, deviceModbusSnap, deviceModbusService, deviceModbusApp, defaultServicePort)
+}
+
+func TestGlobalConfig(t *testing.T) {
+	// start clean
+	utils.SetGlobalConfig(t, deviceModbusSnap, deviceModbusService, defaultServicePort)
+}
+
+func TestMixedConfig(t *testing.T) {
+	utils.SetMixedConfig(t, deviceModbusSnap, deviceModbusService, deviceModbusApp, defaultServicePort)
 }
diff --git a/test/suites/device-modbus/main_test.go b/test/suites/device-modbus/main_test.go
@@ -8,8 +8,11 @@ import (
 	"time"
 )
 
-const deviceModbusSnap = "edgex-device-modbus"
-const deviceModbusService = "edgex-device-modbus.device-modbus"
+const (
+	deviceModbusSnap    = "edgex-device-modbus"
+	deviceModbusApp     = "device-modbus"
+	deviceModbusService = "edgex-device-modbus." + deviceModbusApp
+)
 
 var start = time.Now()