Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix _verify_nova_compute #397

Merged
merged 1 commit into from
May 2, 2024
Merged

Fix _verify_nova_compute #397

merged 1 commit into from
May 2, 2024

Conversation

gabrielcocenza
Copy link
Member

  • logic was getting the app as a string instead of the object
  • fix unit tests

Closes: #393

@gabrielcocenza
Fix _verify_nova_compute
3564796 
- logic was getting the app as a string instead of the object
- fix unit tests

Closes: canonical#393
@gabrielcocenza gabrielcocenza self-assigned this May 1, 2024
@gabrielcocenza gabrielcocenza requested a review from a team as a code owner May 1, 2024 20:38
rgildein
rgildein reviewed May 2, 2024
View reviewed changes
Copy link
Contributor

@rgildein rgildein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only one comment.

cou/apps/auxiliary.py Show resolved Hide resolved
@gabrielcocenza gabrielcocenza merged commit e6f02b6 into canonical:main May 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgildein rgildein rgildein approved these changes

@aieri aieri aieri approved these changes

@Pjack Pjack Awaiting requested review from Pjack Pjack is a code owner automatically assigned from canonical/soleng-reviewers

@samuelallan72 samuelallan72 Awaiting requested review from samuelallan72 samuelallan72 is a code owner automatically assigned from canonical/soleng-reviewers

@jneo8 jneo8 Awaiting requested review from jneo8 jneo8 is a code owner automatically assigned from canonical/soleng-reviewers

Assignees

@gabrielcocenza gabrielcocenza

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error on the auxiliary function _verify_nova_compute
3 participants
@gabrielcocenza @aieri @rgildein