Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error on the auxiliary function _verify_nova_compute #393

Closed
gabrielcocenza opened this issue Apr 29, 2024 · 0 comments · Fixed by #397
Closed

Error on the auxiliary function _verify_nova_compute #393

gabrielcocenza opened this issue Apr 29, 2024 · 0 comments · Fixed by #397
Labels
bug Something isn't working high

Comments

@gabrielcocenza
Copy link
Member

When running _verify_nova_compute the following error appears:

2024-04-29 15:00:07 [cou.steps.execute] [INFO] Running: Verify that all 'nova-compute' units has been upgraded
2024-04-29 15:00:07 [cou.steps] [DEBUG] running step: PreUpgradeStep(Verify that all 'nova-compute' units has been upgraded)
2024-04-29 15:00:15 [cou.cli] [ERROR] Unexpected error occurred.
2024-04-29 15:00:15 [cou.cli] [ERROR] 'str' object has no attribute 'charm'
Traceback (most recent call last):
  File "/home/ubuntu/cocenza/charmed-openstack-upgrader-1/cou/cli.py", line 217, in entrypoint
    loop.run_until_complete(_run_command(args))
  File "/usr/lib/python3.10/asyncio/base_events.py", line 649, in run_until_complete
    return future.result()
  File "/home/ubuntu/cocenza/charmed-openstack-upgrader-1/cou/cli.py", line 203, in _run_command
    await run_upgrade(args)
  File "/home/ubuntu/cocenza/charmed-openstack-upgrader-1/cou/cli.py", line 189, in run_upgrade
    await apply_step(upgrade_plan, args.prompt)
  File "/home/ubuntu/cocenza/charmed-openstack-upgrader-1/cou/steps/execute.py", line 178, in apply_step
    await _run_step(step, prompt, overwrite_progress)
  File "/home/ubuntu/cocenza/charmed-openstack-upgrader-1/cou/steps/execute.py", line 134, in _run_step
    await _run_sub_steps_sequentially(step, prompt, overwrite_substeps_progress)
  File "/home/ubuntu/cocenza/charmed-openstack-upgrader-1/cou/steps/execute.py", line 99, in _run_sub_steps_sequentially
    await apply_step(sub_step, prompt, overwrite_progress)
  File "/home/ubuntu/cocenza/charmed-openstack-upgrader-1/cou/steps/execute.py", line 178, in apply_step
    await _run_step(step, prompt, overwrite_progress)
  File "/home/ubuntu/cocenza/charmed-openstack-upgrader-1/cou/steps/execute.py", line 134, in _run_step
    await _run_sub_steps_sequentially(step, prompt, overwrite_substeps_progress)
  File "/home/ubuntu/cocenza/charmed-openstack-upgrader-1/cou/steps/execute.py", line 99, in _run_sub_steps_sequentially
    await apply_step(sub_step, prompt, overwrite_progress)
  File "/home/ubuntu/cocenza/charmed-openstack-upgrader-1/cou/steps/execute.py", line 178, in apply_step
    await _run_step(step, prompt, overwrite_progress)
  File "/home/ubuntu/cocenza/charmed-openstack-upgrader-1/cou/steps/execute.py", line 134, in _run_step
    await _run_sub_steps_sequentially(step, prompt, overwrite_substeps_progress)
  File "/home/ubuntu/cocenza/charmed-openstack-upgrader-1/cou/steps/execute.py", line 99, in _run_sub_steps_sequentially
    await apply_step(sub_step, prompt, overwrite_progress)
  File "/home/ubuntu/cocenza/charmed-openstack-upgrader-1/cou/steps/execute.py", line 178, in apply_step
    await _run_step(step, prompt, overwrite_progress)
  File "/home/ubuntu/cocenza/charmed-openstack-upgrader-1/cou/steps/execute.py", line 121, in _run_step
    await step.run()
  File "/home/ubuntu/cocenza/charmed-openstack-upgrader-1/cou/steps/__init__.py", line 296, in run
    return await self._task  # wait until task is completed
  File "/home/ubuntu/cocenza/charmed-openstack-upgrader-1/cou/apps/auxiliary.py", line 344, in _verify_nova_compute
    if app.charm != "nova-compute":
AttributeError: 'str' object has no attribute 'charm'
@gabrielcocenza gabrielcocenza added bug Something isn't working high labels Apr 29, 2024
gabrielcocenza added a commit to gabrielcocenza/charmed-openstack-upgrader-1 that referenced this issue May 1, 2024
@gabrielcocenza
Fix _verify_nova_compute
3564796 
- logic was getting the app as a string instead of the object
- fix unit tests

Closes: canonical#393
@gabrielcocenza gabrielcocenza mentioned this issue May 1, 2024
Merged
gabrielcocenza added a commit that referenced this issue May 2, 2024
@gabrielcocenza
Fix _verify_nova_compute (#397)
e6f02b6 
- logic was getting the app as a string instead of the object
- fix unit tests

Closes: #393
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working high
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix _verify_nova_compute gabrielcocenza/charmed-openstack-upgrader-1
1 participant
@gabrielcocenza