Add log to inform skipped(non-empty) hypervisors #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aieri
reviewed
Apr 3, 2024
zxhdaze
force-pushed
the
BSENG-2235/add-nonempty-hypervisor-log
branch
2 times, most recently
from
e368b61 to
ce8ba5a
Compare
zxhdaze
force-pushed
the
BSENG-2235/add-nonempty-hypervisor-log
branch
from
ce8ba5a to
a9db93f
Compare
# This is the 1st commit message: Add log for non-empty hypervisor # This is the commit message canonical#2: Add log for non-empty hypervisor # This is the commit message canonical#3: Add log for non-empty hypervisor
Rebase onto main Rebase onto main move to separate directory Add log for skipped(non-empty) hypervisors with unit test BSENG-2235 Refactor code formatting for lint check BSENG-2235 Refactor code formatting for lint check BSENG-2235 Refactor log to use lazy % formatting BSENG-2235 Refactor string format BSENG-2235 Reformat import BSENG-2235 change logs to display unit names instead of machine names BSENG-2235 reformat code
zxhdaze
force-pushed
the
BSENG-2235/add-nonempty-hypervisor-log
branch
from
a9db93f to
87b03b6
Compare
gabrielcocenza
requested changes
Apr 4, 2024
rgildein
suggested changes
Apr 5, 2024
aieri
requested changes
Apr 6, 2024
reformat code Support OVN apps that don't have "enable-versiong-pinning" config (canonical#359) - Not all ovn apps has this configuration and the current implementation it's not permesive on this. Closes: canonical#348 reformat code reformat code reformat code reformat code reformat code reformat code reformat code reformat code
zxhdaze
force-pushed
the
BSENG-2235/add-nonempty-hypervisor-log
branch
from
a1d7fba to
3a726c5
Compare
zxhdaze
commented
Apr 9, 2024
rgildein
reviewed
Apr 9, 2024
agileshaw
suggested changes
Apr 9, 2024
Co-authored-by: TQ X <[email protected]>
Co-authored-by: TQ X <[email protected]>
gabrielcocenza
requested changes
Apr 10, 2024
agileshaw
previously approved these changes
Apr 10, 2024
gabrielcocenza
approved these changes
Apr 10, 2024
rgildein
approved these changes
Apr 11, 2024
aieri
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #334. Please consider only the latest commit for review until the dependent PR is merged.
Add log to inform user about skipped hypervisors(those having VMs running) at plan stage.
fixes: #326