-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zaza utils #2
Zaza utils #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that zaza could be in lib directory, but other than that LGTM.
Maybe you could also provide commit of hash which was used to get these files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
# This is the 1st commit message: Add log for non-empty hypervisor # This is the commit message canonical#2: Add log for non-empty hypervisor # This is the commit message canonical#3: Add log for non-empty hypervisor
The zaza utilities copied from zaza and zaza-openstack-tests. Their corresponding unit tests are also copied and keep in a seperate module in case we need to update those.
Adding zaza/zaza-openstack-tests would have been an option. However they have tremendous dependencies.