Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zaza utils #2

Merged
merged 8 commits into from
Jun 6, 2023
Merged

Zaza utils #2

merged 8 commits into from
Jun 6, 2023

Conversation

esunar
Copy link
Contributor

@esunar esunar commented Jun 5, 2023

The zaza utilities copied from zaza and zaza-openstack-tests. Their corresponding unit tests are also copied and keep in a seperate module in case we need to update those.

Adding zaza/zaza-openstack-tests would have been an option. However they have tremendous dependencies.

@esunar esunar changed the title Zaza utils WIP: Zaza utils merge after pr#1 Jun 5, 2023
@esunar esunar changed the title WIP: Zaza utils merge after pr#1 Zaza utils Jun 6, 2023
@esunar esunar requested review from a team, Pjack, aieri, jneo8, rgildein and agileshaw June 6, 2023 08:52
Copy link
Contributor

@rgildein rgildein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that zaza could be in lib directory, but other than that LGTM.
Maybe you could also provide commit of hash which was used to get these files.

pyproject.toml Show resolved Hide resolved
@esunar esunar requested a review from gabrielcocenza June 6, 2023 12:25
Copy link
Member

@gabrielcocenza gabrielcocenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@esunar esunar merged commit 267e530 into main Jun 6, 2023
@rgildein rgildein deleted the zaza-utils branch September 11, 2023 15:10
zxhdaze pushed a commit to zxhdaze/charmed-openstack-upgrader that referenced this pull request Apr 4, 2024
# This is the 1st commit message:

Add log for non-empty hypervisor

# This is the commit message canonical#2:

Add log for non-empty hypervisor

# This is the commit message canonical#3:

Add log for non-empty hypervisor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants