Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-3357] Add S3 service account #135

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[DPE-3357] Add S3 service account #135

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
244016c
Add service account support in s3
phvalguima Jan 24, 2024
ea16315
Merge branch 'main' into DPE-3357-add-s3-service-account
gruyaume Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions interfaces/s3/v0/schemas/provider.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,19 @@
]
]
},
"service-account": {
"title": "Service account",
"description": "The service account file content, in base64",
"type": "string",
"items": {
"type": "string"
},
"examples": [
[
"base64-encoded-ca-chain=="
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look like a good example for a service account

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gruyaume This PR has been stopped as we are not yet clear if we will use the s3-integrator for GCS integration. I will move it to a draft state.

]
]
},
"s3-api-version": {
"title": "S3 API signature",
"description": "S3 protocol specific API signature.",
Expand Down
Loading