[DPE-3357] Add S3 service account #135
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gruyaume
reviewed
Feb 27, 2024
| }, | ||
| "examples": [ | ||
| [ | ||
| "base64-encoded-ca-chain==" |
There was a problem hiding this comment.
This doesn't look like a good example for a service account
There was a problem hiding this comment.
Hi @gruyaume This PR has been stopped as we are not yet clear if we will use the s3-integrator for GCS integration. I will move it to a draft state.
|
@phvalguima can you please address my comment? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the service account as an alternative key/ID for users, compared to access_/secret_keys. This is useful, for example, for GCS cloud.
The service account should be passed as a base64 string containing the file content.
This PR is related to: canonical/s3-integrator#26