Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Juju 3.4 support #52

Merged
merged 6 commits into from
Apr 24, 2024

Conversation

rgildein
Copy link
Contributor

@rgildein rgildein commented Apr 18, 2024

Drop unnecessary tox env and Makefile targets and switch from Juju 3.3. to Juju 3.4

Add workflow concurrency to avoid running multiple workflows on a single PR. Like this if new commit arrived the previous run will be canceled by new run.

Blocked until #655 is merged.

Drop unnecesary tox env and Makefile targets and switch from
Juju 3.3. to Juju 3.4
@rgildein rgildein added the enhancement New feature or request label Apr 18, 2024
@rgildein rgildein self-assigned this Apr 18, 2024
@rgildein rgildein requested a review from a team as a code owner April 18, 2024 15:01
@rgildein rgildein requested review from Pjack, aieri and jneo8 April 18, 2024 15:01
@rgildein rgildein force-pushed the release/BSENG-2368/support-juju-3.4 branch from 7aa8117 to bf09cab Compare April 18, 2024 21:37
@rgildein rgildein force-pushed the release/BSENG-2368/support-juju-3.4 branch from bf09cab to 0470419 Compare April 18, 2024 21:38
jneo8
jneo8 previously requested changes Apr 19, 2024
Copy link
Contributor

@jneo8 jneo8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request to add more testing versions and drop 2.9.

.github/workflows/check.yaml Outdated Show resolved Hide resolved
.github/workflows/check.yaml Outdated Show resolved Hide resolved
@rgildein rgildein requested a review from jneo8 April 19, 2024 10:31
Copy link
Contributor

@jneo8 jneo8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall is nice. Wait for CI pass.

tests/functional/tests/test_charm.py Show resolved Hide resolved
@rgildein rgildein requested review from jneo8 and aieri April 22, 2024 12:28
@rgildein rgildein dismissed jneo8’s stale review April 23, 2024 16:28

Those changes was addressed

@rgildein rgildein merged commit 1b88cbf into canonical:main Apr 24, 2024
3 checks passed
@rgildein rgildein deleted the release/BSENG-2368/support-juju-3.4 branch April 24, 2024 09:58
chanchiwai-ray added a commit that referenced this pull request Nov 13, 2024
Add back functional test for bionic and juju 2.9
chanchiwai-ray added a commit that referenced this pull request Nov 13, 2024
Add back functional test for bionic and juju 2.9
chanchiwai-ray added a commit that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants