-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Juju 3.4 support #52
Merged
rgildein
merged 6 commits into
canonical:main
from
rgildein:release/BSENG-2368/support-juju-3.4
Apr 24, 2024
Merged
Add Juju 3.4 support #52
rgildein
merged 6 commits into
canonical:main
from
rgildein:release/BSENG-2368/support-juju-3.4
Apr 24, 2024
+22
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop unnecesary tox env and Makefile targets and switch from Juju 3.3. to Juju 3.4
rgildein
force-pushed
the
release/BSENG-2368/support-juju-3.4
branch
from
April 18, 2024 21:37
7aa8117
to
bf09cab
Compare
rgildein
force-pushed
the
release/BSENG-2368/support-juju-3.4
branch
from
April 18, 2024 21:38
bf09cab
to
0470419
Compare
jneo8
previously requested changes
Apr 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Request to add more testing versions and drop 2.9.
aieri
approved these changes
Apr 19, 2024
jneo8
reviewed
Apr 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall is nice. Wait for CI pass.
jneo8
approved these changes
Apr 24, 2024
aieri
approved these changes
Apr 24, 2024
chanchiwai-ray
added a commit
that referenced
this pull request
Nov 13, 2024
Add back functional test for bionic and juju 2.9
chanchiwai-ray
added a commit
that referenced
this pull request
Nov 13, 2024
Add back functional test for bionic and juju 2.9
Merged
chanchiwai-ray
added a commit
that referenced
this pull request
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop unnecessary tox env and Makefile targets and switch from Juju 3.3. to Juju 3.4
Add workflow concurrency to avoid running multiple workflows on a single PR. Like this if new commit arrived the previous run will be canceled by new run.
Blocked until #655 is merged.