fix: Change juju 3 support strategy #50
Conversation
jneo8
commented
Apr 9, 2024
•
jneo8
commented
- Now all juju 3 will use 3/stable snap release
- Update functional test to run all the supported versions by zaza
- Drop bionic support
- Now all juju 3 will use 3/stable snap release - Update functional test to run all the supported versions by zaza - Drop bionic support
jneo8
force-pushed
the
fix/change-juju-3.x-support-strategy
branch
from
bbbc6bd
to
cf6034b
Compare
jneo8
force-pushed
the
fix/change-juju-3.x-support-strategy
branch
2 times, most recently
from
5d017f1
to
576e468
Compare
jneo8
force-pushed
the
fix/change-juju-3.x-support-strategy
branch
from
576e468
to
0ce608d
Compare
- Now it's pass from the workflow command, not from the Makefile - Default set to 3.3/stable
jneo8
force-pushed
the
fix/change-juju-3.x-support-strategy
branch
from
186b194
to
f0df26b
Compare
|
Since this testing strategy is a bit more different than what we're used to with other charms, it would be nice to include some documentation around this -- how we're testing the various juju versions, libjuju, zaza details, about env vars like |
I feel it's should be document in zaza, not here. Right? |
I was thinking more along the lines of how we are using zaza + other details specifically for these tests. But if it seems trivial, then we can ignore my comment. The changes LGTM :) |
| @CHARM_LOCATION=${PROJECTPATH} tox -e func33-focal -- ${FUNC_ARGS} | ||
| functional3: build | ||
| @echo "Executing functional tests using built charm at ${PROJECTPATH} with juju 3.x requirements" | ||
| @TEST_JUJU_CHANNEL=${TEST_JUJU_CHANNEL} TEST_JUJU3=1 CHARM_LOCATION=${PROJECTPATH} tox -e func3 -- ${FUNC_ARGS} |
There was a problem hiding this comment.
Could we add a comment explaining the usage of TEST_JUJU3 similar to Robert's juju 3.4 support PR?
rgildein
dismissed
their stale review
Do not want to block these, since we will change it again soon with 3.4 support.
|
Cover by #52 |
