Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add rust compiler to charms #1178

Open
11 tasks
orfeas-k opened this issue Dec 4, 2024 · 2 comments
Open
11 tasks

build: Add rust compiler to charms #1178

orfeas-k opened this issue Dec 4, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@orfeas-k
Copy link
Contributor

orfeas-k commented Dec 4, 2024

Context

Hit during #1156 and #1177, we hit the issue where charms fail to be built due to the absence of a rust compiler during build time.

  • argo-controller
  • kfp charms apart from metadata-writer
  • knative charms
  • kserve-controller
  • kubeflow-profiles-operator
  • volumes-operator
  • metacontroller-operator
  • minio-operator
  • namespace-node-affinity-operator
  • ngc-integrator
  • training-operator

What needs to get done

Add appropriate dependencies as we previously did canonical/kubeflow-dashboard-operator@c31941b or follow what mysql-k8s team is doing seen here canonical/charmcraft#1722 (comment). The latter proved to be building faster the charm ( 12 minutes compared to 18 minutes for argo-controller)

Definition of Done

Charms can be built with dependencies requiring a rust compiler.

@orfeas-k orfeas-k added the enhancement New feature or request label Dec 4, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-6645.

This message was autogenerated

@orfeas-k
Copy link
Contributor Author

orfeas-k commented Dec 5, 2024

KFP

KFP tests fail due to space in the runner as seen here https://github.com/canonical/kfp-operators/actions/runs/12162787081/job/33958507596?pr=631#step:5:468 (same as canonical/kfp-operators#602)

FAILED tests/integration/test_kfp_functional_v2.py::test_create_and_monitor_run - AssertionError: assert 'FAILED' == 'SUCCEEDED'
  
  - SUCCEEDED
  + FAILED

and here https://github.com/canonical/kfp-operators/actions/runs/12162787081/job/33958506393?pr=631#step:5:442

unit-kfp-profile-controller-0: 08:30:35 ERROR juju.worker.uniter.operation hook "update-status" (via unknown/invalid hook handler) failed: starting jujuc server: listening to jujuc socket: mkdir /var/lib/juju/agents/unit-kfp-profile-controller-0/426642296: no space left on device

This means that adding rust compiler to the charms needs first this feature to land canonical/kfp-operators#627.

orfeas-k added a commit to canonical/kserve-operators that referenced this issue Dec 5, 2024
orfeas-k added a commit to canonical/kubeflow-profiles-operator that referenced this issue Dec 5, 2024
orfeas-k added a commit to canonical/kubeflow-volumes-operator that referenced this issue Dec 5, 2024
orfeas-k added a commit to canonical/metacontroller-operator that referenced this issue Dec 5, 2024
orfeas-k added a commit to canonical/minio-operator that referenced this issue Dec 5, 2024
orfeas-k added a commit to canonical/namespace-node-affinity-operator that referenced this issue Dec 5, 2024
orfeas-k added a commit to canonical/ngc-integrator-operator that referenced this issue Dec 5, 2024
orfeas-k added a commit to canonical/training-operator that referenced this issue Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant