Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to grpc-dotnet #348

Closed
ChrisKujawa opened this issue Oct 27, 2021 · 7 comments · Fixed by #545
Closed

Migrate to grpc-dotnet #348

ChrisKujawa opened this issue Oct 27, 2021 · 7 comments · Fixed by #545
Assignees
Labels

Comments

@ChrisKujawa
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

https://grpc.io/blog/grpc-csharp-future/

TL;DR grpc-dotnet (the Grpc.Net.Client and Grpc.AspNetCore.Server nuget packages) is now the recommended gRPC implementation for .NET/C#. The original gRPC C# implementation (the Grpc.Core nuget package) will enter maintenance mode and won’t be getting any new features and will only receive important bug fixes and security fixes going forward. The ultimate plan is to phase out Grpc.Core completely at some point in the future. This announcement describes the reasons why we have decided to do so and lays out the plan in more detail.

Describe the solution you'd like

Describe alternatives you've considered

Stick with the grpc-core

Additional context

This would solve #194

@arjangeertsema
Copy link

Hey @Zelldon, it has been a long time since there has been a release of a new version. What is you policy regarding not falling to for behind software updates?

My bootstrap project is highly dependent of your project and I would regret to see that it will be failing because of this.

For the time being could you add Apple M1 support to your project? (https://github.com/einari/Grpc.Core.M1)

Hopefully you will be able to release a new version which will fix a lot of issues including this one.

Thanks!

Arjan

@ChrisKujawa
Copy link
Collaborator Author

Tbh I was also thinking for a while to create a new release but always miss it. I try to do it soon. Please remind me if I miss it again

@ChrisKujawa
Copy link
Collaborator Author

@arjangeertsema https://github.com/camunda-community-hub/zeebe-client-csharp/releases/tag/1.3

@jothikiruthika
Copy link

Hi @Zelldon, now that .net 3.1 has already reached EOL, developers naturally look forward to code with .net 6.0 & Above. But the zb-client library has an internal dependency on Grpc.core, this has to be migrated to grpc-dotnet Without this support in the C# client, we are forced to stick to .net core 3.1 on the MAC, since the native Grpc library in C# is not available for arm based images.

@xlegalles
Copy link
Contributor

Can we help? (contribute)

@xomiamoore
Copy link
Contributor

Hey @xlegalles, absolutely, contributions are welcome!

@xlegalles
Copy link
Contributor

xlegalles commented May 17, 2023

I've pushed a PR #517
Note that I made this version for .NET 5, 6 and 7 because 3.1 has reached its end of support on December 13, 2022.

xlegalles added a commit to xlegalles/zeebe-client-csharp that referenced this issue May 31, 2023
deps(client): uses Grpc.Net instead of Grpc.Core
fix: camunda-community-hub#348
xlegalles added a commit to xlegalles/zeebe-client-csharp that referenced this issue May 31, 2023
deps(client): uses Grpc.Net instead of Grpc.Core
fix: camunda-community-hub#348
This was referenced Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants