Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to grpc-dotnet is not actually done #554

Closed
jSharpWolf opened this issue Aug 8, 2023 · 3 comments · Fixed by #556
Closed

Migration to grpc-dotnet is not actually done #554

jSharpWolf opened this issue Aug 8, 2023 · 3 comments · Fixed by #556
Assignees
Labels
bug Something isn't working

Comments

@jSharpWolf
Copy link

jSharpWolf commented Aug 8, 2023

Describe the bug
The migration issue has been closed with release 2.0 (#348), however the migration is incomplete, and Grpc.Core is still being used. Thus using the ZbClient fails on M1 macs.

In this commit ee36df8 a new package was added, but the code hasn't been adjusted to use the new package. Instead, the "Grpc" dependency has not been changed (2.46.6) and still uses Grpc.Core

To Reproduce
Check in IDE - it clearly still refers to Grpc.Core:
image

or

Try to connect to a Zeebe broker on M1 macs

Expected behavior
The client should not depend on Grpc.Core. The Grpc Nuget package should not be listed in the Client.csproj.

The classes also differ, this is how it should be:
image

Instead of using "Channel" "GrpcChannel" must be used, instead of using "ChannelOptions" GrpcChannelOptions" must be used

@jSharpWolf jSharpWolf added the bug Something isn't working label Aug 8, 2023
@ChrisKujawa
Copy link
Collaborator

Interesting! Thanks for the report, I must have overseen this somehow sorry. I try to take a look as soon as I can.

@xlegalles
Copy link
Contributor

Interesting! Thanks for the report, I must have overseen this somehow sorry. I try to take a look as soon as I can.

You can take a look at the PR I did, and use GrpcChannel instead: https://github.com/camunda-community-hub/zeebe-client-csharp/pull/517/files#diff-9e614288d9ef8da794637095109c1ce073b0b71ca5cac3eddff724531f931f56

Also, note that we use v2.0 in production on Linux Ubuntu and all is fine until now.

@ChrisKujawa
Copy link
Collaborator

@jSharpWolf thanks for reporting! It should be fixed with the latest release https://github.com/camunda-community-hub/zeebe-client-csharp/releases/tag/2.1.0

I migrated to the new Grpc.net.GrpcChannel and had to migrate several other things, but it should be done now. Be aware Grpc.Core will not completely go away, since it contains several utilities which are also used in Grpc.net.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants