Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zone picking show when location will be empty #91

Merged
merged 11 commits into from
Oct 5, 2020
Merged

Zone picking show when location will be empty #91

merged 11 commits into from
Oct 5, 2020

Conversation

simahawk
Copy link
Member

@simahawk simahawk commented Oct 5, 2020

continues #90

ref: 1630

@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2020 •
edited
Loading

Codecov Report

Merging #91 into 13.0-shopfloor will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           13.0-shopfloor      #91   +/-   ##
===============================================
  Coverage           92.63%   92.63%           
===============================================
  Files                  55       55           
  Lines                3991     3991           
===============================================
  Hits                 3697     3697           
  Misses                294      294
Impacted Files Coverage Δ
shopfloor/services/zone_picking.py 95.38% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 294d4d6...b9df51c. Read the comment docs.

jgrandguillaume
jgrandguillaume approved these changes Oct 5, 2020
View reviewed changes
Copy link
Member

@jgrandguillaume jgrandguillaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thoug I would merge lot and pack column if we can easily do that to save space.

@simahawk
Copy link
Member Author

simahawk commented Oct 5, 2020

LGTM ! Thoug I would merge lot and pack column if we can easily do that to save space.

done in last commit

@simahawk simahawk merged commit eabce58 into camptocamp:13.0-shopfloor Oct 5, 2020
TDu pushed a commit that referenced this pull request Dec 15, 2020
@OCA-git-bot
Merge PR #91 into 13.0
8a53946 
Signed-off-by simahawk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guewen guewen guewen approved these changes

@jgrandguillaume jgrandguillaume jgrandguillaume approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@simahawk @codecov-commenter @jgrandguillaume @guewen