Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] shopfloor: zone_picking, show if location are about to be empty #90

Merged
merged 2 commits into from
Oct 1, 2020

Conversation

sebalix
Copy link
Member

@sebalix sebalix commented Sep 30, 2020

On select_line screen, inform the user that if he process this move line he will empty the location.
This could mean for him that he'll be able to retrieve a pallet at the same time without taking one in another place to prepare the goods.

Issue 1630

TODO: update the frontend to display the new field empty_location_src on select_line screen. Help me @simahawk, you're my only hope.

On 'select_line' screen, inform the user that if he process this move line
he will empty the location.
This could mean for him that he'll be able to retrieve a pallet at the
same time without taking one in another place to prepare the goods.
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2020

Codecov Report

Merging #90 into 13.0-shopfloor will increase coverage by 1.57%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           13.0-shopfloor      #90      +/-   ##
==================================================
+ Coverage           91.06%   92.63%   +1.57%     
==================================================
  Files                  55       55              
  Lines                3972     3991      +19     
==================================================
+ Hits                 3617     3697      +80     
+ Misses                355      294      -61     
Impacted Files Coverage Δ
shopfloor/models/stock_location.py 100.00% <100.00%> (ø)
shopfloor/services/zone_picking.py 95.38% <100.00%> (+0.06%) ⬆️
shopfloor/models/stock_picking.py 95.45% <0.00%> (-4.55%) ⬇️
shopfloor/actions/message.py 92.00% <0.00%> (+2.66%) ⬆️
shopfloor/services/delivery.py 95.47% <0.00%> (+17.69%) ⬆️
shopfloor/services/scan_anything.py 100.00% <0.00%> (+33.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e07718...4d89f06. Read the comment docs.

Copy link
Member

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as per UI: what do you have to show?

shopfloor/services/schema.py Outdated Show resolved Hide resolved
shopfloor/services/zone_picking.py Outdated Show resolved Hide resolved
shopfloor/actions/data.py Outdated Show resolved Hide resolved
@sebalix
Copy link
Member Author

sebalix commented Sep 30, 2020

@simahawk need to show this icon https://fontawesome.com/icons/empty-set if the move line is about to empty its source location (empty_location_src data entry).

@simahawk
Copy link
Member

I'll use another one because we are using material design icons ;)

@simahawk simahawk merged commit 294d4d6 into camptocamp:13.0-shopfloor Oct 1, 2020
@simahawk
Copy link
Member

simahawk commented Oct 1, 2020

I'll address the frontend part in a new PR

simahawk pushed a commit to simahawk/wms that referenced this pull request Oct 12, 2020
…tocamp#90)

* shopfloor: zone_picking, show if location are about to be empty

On 'select_line' screen, inform the user that if he process this move line
he will empty the location.
This could mean for him that he'll be able to retrieve a pallet at the
same time without taking one in another place to prepare the goods.
@sebalix sebalix deleted the 13.0-shopfloor-1630 branch October 19, 2020 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants