Use escaped label as id for querygrid, because id are not unique #3622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrunner
approved these changes
Mar 6, 2018
ger-benjamin
force-pushed
the
fix_displayquerygrid_display
branch
from
2dc46a1 to
701ca96
Compare
pfirpfel
reviewed
Mar 6, 2018
| @@ -212,6 +212,7 @@ gmf.DisplayquerygridController = function($injector, $scope, ngeoQueryResult, ng | |||
|
|
|||
| /** | |||
| * @type {!gmfx.GridMergeTabs} | |||
| * @export | |||
There was a problem hiding this comment.
Just a note: this fixes #3508
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX: GEO-1022
The id in the querysources is not always unique (not in case of multiple server layers in one ol layer). And the querygrid already use label as ID to be able to merge the layers and because that make no sens to have multiple tabs with the same name, so to be based on id is a bad idea. Having a mix of id/label is also a bad idea.
Now all is based on labels. Note that we must escape the label to be able to use and select it as class or id (and avoid to fall again in this issue: #3273)