Display query grid: No titles in tabs of second row

[svades]

Project:

• GitHub URL: https://github.com/camptocamp/baselstadt_mapbs
• GeoMapFish version: 2.2.1

Steps to reproduce the issue:

• do a query over a surface
• open a tab in the second row
• the titles of the tabs in the second row are broken

Result:

As soon as there are two rows of tabs in the display query grid the titles are broken.

[sbrunner]

see: elboletaire/tabbedcontent#19

[ger-benjamin]

@svades I can't reproduce this issue (I've 2 lines of tabs with a normal style. But I've lesser tabs). Which browser (and version) do you use, and on which OS ?

[svades]

It usually happens at the eleventh, twelfth, thirteenth... tab.
I use IE11 (Version 11.0.9600.18860) and I could also reproduce it in Chrome (Version 63.0.3239.108) and Firefox ESR (52.4.1) on Windows 7 Enterprise.

[ybolognini]

@llienher Please check with more than 10 tabs

[llienher]

@svades We merged a fix for an issue related to merged tabs for 2.2.2 minor release. We saw that when a merged tabs is defined with a name containing space, brackets, parenthenses, etc, the grid headers would break because the html would use the name defined in the controller as element id. This way the CSS selector was broken in the javascript as it was trying to retrieve several ids (from the spaces), not just the one element we wanted to 'reflow' the grid at tab selection.

Our fix should not affect any project setup as the controller setup (mergeTabs) will be the same as now. But the issue is not related to having more than 10 tabs, while the consequences where similar to what you described.

Please reopen this issue if it's there is any remaining issue when you are able to test 2.2.2 in your project.

[svades]

I could now test in in gmf 2.2.2 and there is an error doing a request over a surface:

The displayQueryGrid remains empty:

[llienher]

Thanks for you feedback, I'm reopening this issue. I'm still not sure if it is related the the initial fix we addressed here.

Do you have an instance where I can see this issue more in detail ?

[svades]

Our branch "gmf222" is where we updated the master to gmf 2.2.2.
Unfortunately, the URL (map.geo.dev.bs.ch/ngeodesktop) is not reachable for you because it is on our development environment.

[jwkaltz]

Hi Silvana, we checked this functionality on our demo project; the default demo project does not use the displayquerygrid, but we built a test instance 2.2.2 with Laurent that does activate the displayquerygrid: https://gmf-test.sig.cloud.camptocamp.net/llienher
The query works fine, there. We suspect that the JavaScript error you mention comes from a Baselstadt specific adaptation. Can you please verify that, and, if needed, open a support ticket?

[svades]

Hi,
I could reproduce the issue on your demo project.
I loaded all the layers in the theme "Demo" and did a request over a big surface. Then the displayquerygrid appears but is white and empty (see screenshot).

[llienher]

Hi,

I have been able to narrow the issue to the 'two layers' in the demo (not my own test instance, it's not reliable) and precisely break the grid...
I'm going to open a new issue to this problem.

[llienher]

New issue opened here:
#3462