-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
glossary alignment #40
glossary alignment #40
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me.
We will introduce the UTC precision later?
We can include it in the PR we have to open for #42 |
Added UTC Precision (camaraproject#43) + Error Message (camaraproject#44 (comment))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added UTC precision + error code 404 to accomodate both issue open.
@bigludo7 are we going to wait for the commonalities issue about this to get resolved or are we going to merge this PR and then align it with the decision afterwards? |
@monamok I suggest to wait tomorrow Commonalities call. Probably good to inform @DT-DawidWroblewski. I should not be able to connect tomorrow to the Commonalities call so hope someone can trigger the discussion (Dawid, you or @gregory1g ) |
@bigludo7 I removed UTC for the moment so if you approve and @DT-DawidWroblewski agrees too, we can merge and close this PR tomorrow during the bi-weekly meeting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK work for me as well.
We can create another PR for UTC after.
Let's go for this
@bigludo7 thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good
What type of PR is this?
What this PR does / why we need it:
The parameters naming alignment with Glossary
Which issue(s) this PR fixes:
Fixes (#41)
Special notes for reviewers:
Changelog input
Changelogs will be included once #28 in accepted and merged
Additional documentation