Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UTC precision for SIMswap date. #43

Closed
bigludo7 opened this issue Jun 8, 2023 · 8 comments
Closed

Add UTC precision for SIMswap date. #43

bigludo7 opened this issue Jun 8, 2023 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@bigludo7
Copy link
Collaborator

bigludo7 commented Jun 8, 2023

Problem description
What is the time zone for the date time provided by the SIM swap get date?

Possible evolution
Indicate in the description that we use UTC (Coordinated Universal time)
I guess this in implicit right now but better to be explicit?

@monamok @DT-DawidWroblewski WDYT?

@bigludo7 bigludo7 added the enhancement New feature or request label Jun 8, 2023
@monamok
Copy link
Collaborator

monamok commented Jun 12, 2023

We usually for these kind of parameters use descriptions like this for example:

Timestamp of latest SIM swap performed, in ISO-8601 extended local date format. Time-offset from UTC may be used to match the local time.

but besides being date-time we don't force it. How do you suggest to have it as explicit? With a pattern?

@bigludo7
Copy link
Collaborator Author

@monamok Thanks. No I did no plan to change the attribute formatting. My proposal was just to update the description to make it explicit.

@monamok
Copy link
Collaborator

monamok commented Jun 12, 2023

Thank you @bigludo7. The example I added was more kind of recommendation without saying explicitly that it must be UTC, It's more focused on ISO-8601 standard. Do you think using UTC must be part of the guideline? I'm not sure if there are more APIs over CAMARA that use date-time parameters.

P.D. I opened this issue #42 last week in order to improve and align the documentation with the guidlines. Once decided, we can include this point in a common PR for both issues.

@bigludo7
Copy link
Collaborator Author

@monamok : I will propose a very small update in the design guideline document to indicate that datetime attribute has to use UTC (if nothing explicitly else).

@bigludo7
Copy link
Collaborator Author

camaraproject/Commonalities#14 ;)

@monamok
Copy link
Collaborator

monamok commented Jun 12, 2023

Thank you @bigludo7

bigludo7 added a commit to monamok/SimSwap that referenced this issue Jun 13, 2023
@gregory1g
Copy link
Collaborator

Why it must be UTC? "ISO 8601" includes timezone as well, so the API client does not need to have any assumptions on its side.

@DT-DawidWroblewski
Copy link
Collaborator

AP - take this item to commonalities

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants