-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add subscriptionMaxEvents for maximum number of notifications (geofencing) #163
feat: add subscriptionMaxEvents for maximum number of notifications (geofencing) #163
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bigludo7 v0.2.0 for DeviceLocation was released yesterday. That's why I used here v0.2.0-wip. |
Yes, until we have clear rules for API family versioning, I think we should continue with our current one, so new updates on geofencing should be part of 0.2.0-wip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to consolidate #162 on this to avoid with conflicts
thanks for the review. |
fix: add changes from camaraproject#162 Co-authored-by: Jose Luis Urien <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #111
Fixes #161