Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add x-correlator as specified in the guideline #160

Closed
bigludo7 opened this issue Mar 5, 2024 · 4 comments
Closed

Add x-correlator as specified in the guideline #160

bigludo7 opened this issue Mar 5, 2024 · 4 comments

Comments

@bigludo7
Copy link
Collaborator

bigludo7 commented Mar 5, 2024

Problem description
A specified in Commonalities we have to add x-correlator in our 3 APIs (see camaraproject/Commonalities#115)

Expected behavior
Add in the request:

parameters:
        - $ref: '#/components/parameters/x-correlator'

Add in all API response:

          headers:
            x-correlator:
              $ref: '#/components/headers/x-correlator'

Alternative solution
No alternative

Additional context

@bigludo7
Copy link
Collaborator Author

bigludo7 commented Mar 5, 2024

@jlurien This one should be an easy to fix but prefer to have guidance on versioning before to propose any PR.

@jlurien
Copy link
Collaborator

jlurien commented Mar 5, 2024

Yes, we have to align to latest version of the Guidelines, but I prefer to close Release 0.2.0 as it is, and include new changes for upcoming 0.3.0-wip, otherwise we never move forward, because we'd need to create another RC and so on

@bigludo7
Copy link
Collaborator Author

bigludo7 commented Mar 5, 2024

Yes, we have to align to latest version of the Guidelines, but I prefer to close Release 0.2.0 as it is, and include new changes for upcoming 0.3.0-wip, otherwise we never move forward, because we'd need to create another RC and so on

Works for me !
I wait for some sync in next meeting to make any PR on this topic.

bigludo7 added a commit that referenced this issue Mar 12, 2024
Update location-verification with x-correlator
Issue #160
bigludo7 added a commit that referenced this issue Mar 12, 2024
Update location-retrieval with x-correlator
This PR partially solve Issue #160
(2 other PR will come for the 2 other APIs)
bigludo7 added a commit that referenced this issue Mar 15, 2024
Update location-verification with x-correlator
This PR partially solve Issue #160
(2 other PR are done for the 2 other APIs)
@bigludo7
Copy link
Collaborator Author

bigludo7 commented Apr 9, 2024

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants