-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for rippleColor in android #56
Added support for rippleColor in android #56
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
Can you check how the ripple color looks like when using Material Design 3?
I've added guide on how to change the styles here: https://github.com/okwasniewski/react-native-bottom-tabs/blob/docs/content-update/docs/docs/docs/guides/android-native-styling.md
(It doesn't work for expo yet, but it should work in Example App)
I have tested it using material design 3 this is how it looks screen-recording-20241018-235959_BXZypA1t.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Part of this: #11
Summary: This PR updates the ripple color of tab bar click for Android implementations.
Testing:
Verified Ripple color changes on Android.
Added FourTabsRippleColor for visual changes.
Adding Video for reference
screen-recording-20241018-161121_vXx8zzso.mp4