-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
☂ TabView Configuration #11
Comments
just an idea, but we could use the |
https://developer.apple.com/documentation/uikit/uitabbar/3750912-scrolledgeappearance |
Working on tint color |
I am looking into I checked JS bottom tabs there we have Is this okay @okwasniewski |
Hey @shubhamguptadream11 great to have you as a contributor! 👍🏻 There is an open PR #42 adding tint colors should be merged soon so I think you can work on something different. |
@okwasniewski Is |
Ah no, its not! Sorry 😅 Go ahead 👍🏻 |
I want to look into |
Hey @sarthak-d11 I updated the issue description looks like |
In that case, Can I look into |
Sure! I'll assign you |
Current Behavior in JS Bottom Tabs Related to Background Color of Tabs Prop Names:
To illustrate the behavior, let’s consider the following code:
Initial Setup:
Behavior at Initial Mount:
Behavior on Switching to Albums:
Behavior on Switching to Contacts:
Summary:
Note: Attaching video for reference: @okwasniewski |
Thanks for outlining how it works on JS tabs! A while ago there was Native Tab Bar implementation inside of RN Core (https://github.com/facebook/react-native/blob/v0.56.0/React/Views/RCTTabBar.m) It supported I'm not sure if setting the color of individual items makes sense for the native tab bar I think for custom scenarios users should pick JS Tab Bar. My idea with this prop was to change the tab bar background at the navigator level (which in this case doesn't need to be divided into active and inActive). Let me know what you think, maybe there is a use case to change colors per tab but I don't think native components support it anyways. |
@okwasniewski I also checked iOS implementation there we have barTintColor or UITabBarAppearance().backgroundColor which basically set the I am going with this approach in both platform |
@okwasniewski This is what I understood. translucent (iOS)
Doubt: How will it override already applied barTintColor? activeIndicatorColor(Android): |
Yes! This was also available in RN Core before: https://github.com/facebook/react-native/blob/v0.56.0/React/Views/RCTTabBar.m
Im guessing It won't have any effect because if you set the background of the tab bar its not translucent anymore.
For Material Design 3 there is an active indicator, there is an API This involves double checking how it works with #42 |
Got it. @okwasniewski Can you assign Since |
I moved dissapear on scroll to a separate issue so we are only missing With this implemented we will be able to have fully custom colored TabView! FYI, it's |
Yeah sure!! |
The goal of this umbrella issue is to implement missing configuration options for TabView:
barTintColor
- Background color of the tab bar (@shubhamguptadream11) Added support for barTintColor in android ios #55activeTintColor
- Color of the active tab icon and label. (Handled in Adding Active Inactive Tint Color #42)inactiveTintColor
- Color of the inactive tab icon and label. (Handled in Adding Active Inactive Tint Color #42)translucent
- (iOS) A Boolean value that indicates whether the tab bar is translucent (@shubhamguptadream11)rippleColor
(Android) - Color of ripple effect (@sarthak-d11) Added support for rippleColor in android #56activeIndicatorColor
(Android) - Color of tab indicator (@shubhamguptadream11)The text was updated successfully, but these errors were encountered: