feat: Zoho Calendar #8144
feat: Zoho Calendar #8144
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@murtajaziad is attempting to deploy a commit to the cal-staging Team on Vercel. A member of the Team first needs to authorize it. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
|
@murtajaziad Thanks for the PR !! I am wondering if #7182 added similar functionality already or not. Also, if it didn't would it make sense to add the functionality into that existing app. |
HI @hariombalhara, I have just checked #7182 and it doesn't include any Zoho Calendar functionality, it uses the events/meetings module that's provided by the CRM API. Also, Zoho Calendar and Zoho CRM are two different products that apparently don't overlap. |
|
@PeerRich can you confirm if we want to do it in a separate app? |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Four Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Four Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Four Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
| - /api/app-store/zohocalendar/ZCal1.jpg | ||
| --- | ||
|
|
||
| Zoho Calendar is an online business calendar that makes scheduling easy for you. You can use it to stay on top of your schedule and also share calendars with your team to keep everyone on the same page. |
There was a problem hiding this comment.
@sydwardrae @Jaibles Please review App description
PeerRich
added
app-store
|
Thank you for following the naming conventions! 🙏 |
There was a problem hiding this comment.
Made some changes and I think it should be good to go now.
Leaving last approve to @hariombalhara
There was a problem hiding this comment.
Auto-generated files shouldn't be committed.
There was a problem hiding this comment.
Auto-generated files shouldn't be committed.
There was a problem hiding this comment.
Auto-generated files shouldn't be committed.
There was a problem hiding this comment.
Auto-generated files shouldn't be committed.
There was a problem hiding this comment.
I like this approach of adding instructions in the app package.
| try { | ||
| const query = stringify({ eventdata: JSON.stringify(this.translateEvent(event)) }); | ||
|
|
||
| const eventResponse = await this.fetcher(`/calendars/${calendarId}/events/${eventId}?${query}`, { |
There was a problem hiding this comment.
This endpoint requires an etag that we can get by first retrieving the event on the calendar. This is to ensure that the calendar event wasn't updated while this request is being made.
| * @param event | ||
| * @returns | ||
| */ | ||
| async deleteEvent(uid: string, event: CalendarEvent, externalCalendarId?: string) { |
There was a problem hiding this comment.
Also getting a missing etag error for this method.
|
This PR is being closed due to inactivity. Please reopen if work is intended to be continued. |
What does this PR do?
An app to integrate Zoho Calendar and Cal.com using the official Zoho Calendar API.
Fixes #5451
Environment: Staging(main branch)
Type of change
How should this be tested?
No automated tests are set up for this.
You can manually test the integration by following these steps:
Checklist
/claim #5451