-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Zoho Calendar #10429
feat: Zoho Calendar #10429
Conversation
Co-authored-by: Hariom Balhara <[email protected]>
@aar2dee2 can't reproduce |
.filter((freebusy: FreeBusy) => freebusy.fbtype === "busy") | ||
.map((freebusy: FreeBusy) => ({ | ||
// using dayjs utc plugin because by default, dayjs parses and displays in local time, which causes a mismatch | ||
start: dayjs.utc(freebusy.startTime, "YYYYMMDD[T]HHmmss[Z]").toISOString(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
}), | ||
}); | ||
|
||
const eventResponse = await this.fetcher(`/calendars/${calendarId}/events/${uid}?${query}`, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should handle it gracefully, by creating the event on rescheduled time.
Though not a blocker, we can create a ticket for it and work on it later.
Thankyou @murtajaziad 🙏 Overall it works well, left a few comments but they can be addressed in a followup. @aar2dee2 if you don't have any more concerns let's merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested
- Fresh Booking
- Rescheduling
- Availability
yes, let's proceed |
fixed when |
Co-authored-by: Hariom Balhara <[email protected]> Co-authored-by: alannnc <[email protected]> Co-authored-by: Joe Au-Yeung <[email protected]> Co-authored-by: Joe Au-Yeung <[email protected]> Co-authored-by: Peer Richelsen <[email protected]> Co-authored-by: aar2dee2 <[email protected]>
What does this PR do?
An app to integrate Zoho Calendar and Cal.com using the official Zoho Calendar API.
This PR is a reopen of already-existing closed PR #8144 with all the required changes done.
Fixes #5451
Environment: Staging(main branch)
Type of change
How should this be tested?
No automated tests are set up for this.
You can manually test the integration by following these steps:
Checklist
/claim #5451