Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Zoho Calendar #10429

Merged
merged 54 commits into from
Sep 25, 2023
Merged

feat: Zoho Calendar #10429

merged 54 commits into from
Sep 25, 2023

Conversation

murtajaziad
Copy link
Contributor

What does this PR do?

An app to integrate Zoho Calendar and Cal.com using the official Zoho Calendar API.

This PR is a reopen of already-existing closed PR #8144 with all the required changes done.

Fixes #5451

Environment: Staging(main branch)

Type of change

  • New feature (non-breaking change which adds functionality)

How should this be tested?

No automated tests are set up for this.
You can manually test the integration by following these steps:

  1. Link your Zoho account with your Cal.com account.
  2. Set your default calendar for creating the events to your Zoho Calendar.
  3. Book an event to try the integration.

Checklist

  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

/claim #5451

Co-authored-by: Hariom Balhara <[email protected]>
@murtajaziad
Copy link
Contributor Author

For a slot booked on Zoho directly I was able to double book using my Cal link.

@aar2dee2 can't reproduce
image
image

.filter((freebusy: FreeBusy) => freebusy.fbtype === "busy")
.map((freebusy: FreeBusy) => ({
// using dayjs utc plugin because by default, dayjs parses and displays in local time, which causes a mismatch
start: dayjs.utc(freebusy.startTime, "YYYYMMDD[T]HHmmss[Z]").toISOString(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This throws error when I enable 'Show me busy during non-work hours option', reason being the date format sent by Zoho changes in that case.
image
Screenshot 2023-09-25 at 1 01 22 PM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I think it makes sense to document somewhere that one needs to enable this free busy option for events to be considered as busy.
image

}),
});

const eventResponse = await this.fetcher(`/calendars/${calendarId}/events/${uid}?${query}`, {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-09-25 at 1 10 14 PM If for the booking being rescheduled in Cal.com, Zoho calendar event doesn't exist due to some reason(I deleted that in my case), there comes an error in rescheduling the event on Zoho.

I think we should handle it gracefully, by creating the event on rescheduled time.
Though not a blocker, we can create a ticket for it and work on it later.

@hariombalhara hariombalhara removed ❗️ migrations contains migration files ❗️ .env changes contains changes to env variables labels Sep 25, 2023
@hariombalhara
Copy link
Member

Thankyou @murtajaziad 🙏 Overall it works well, left a few comments but they can be addressed in a followup.

@aar2dee2 if you don't have any more concerns let's merge it.

Copy link
Member

@hariombalhara hariombalhara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

  • Fresh Booking
  • Rescheduling
  • Availability

@aar2dee2
Copy link
Contributor

Thankyou @murtajaziad 🙏 Overall it works well, left a few comments but they can be addressed in a followup.

@aar2dee2 if you don't have any more concerns let's merge it.

yes, let's proceed
@hariombalhara

@hariombalhara hariombalhara merged commit 70461b2 into calcom:main Sep 25, 2023
26 of 28 checks passed
@aar2dee2
Copy link
Contributor

For a slot booked on Zoho directly I was able to double book using my Cal link.

@aar2dee2 can't reproduce image image

fixed when Include in free/busy is selected in Zoho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar ✨ feature New feature or request Medium priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-345] Integration with Zoho calendar
9 participants