-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add spinner to Check Status button #1043
Conversation
7422fd4
to
3469e9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Wait why only for reCAPTCHA? |
Oops that's false actually. I added the spinner divs to both branches of the code so it'll show up without reCaptcha too. |
Shelving this for the time being until #1068 bug is resolved. |
@machikoyasuda did you want someone to grab this one now that #1068 is merged? |
@thekaveman yeah I was planning to - but you can do this ticket too! Whichever. |
closes #948
What this PR does
form.submitting_value
.submitting_value
(Checking
), so the spinner shows up there. No other place in the current app has a form with asubmitting_value
.Button with Spinner element
Spinner:
role="status"
for a11yButton with Spinner:
<button>
with two<span>
sTesting