Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add spinner to Check Status button #1043

Closed
wants to merge 3 commits into from
Closed

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented Oct 12, 2022

closes #948

What this PR does

  • Add Spinner to button if the button has a form.submitting_value.
  • The Eligibility Verification form has a submitting_value (Checking), so the spinner shows up there. No other place in the current app has a form with a submitting_value.

Button with Spinner element

image

Spinner:

image

Button with Spinner:

  • <button> with two <span>s
  • One span for text, one span for spinner. (If these are in the same span, then the whole text would also rotate).

Testing

  • Test all other buttons for height/size
  • Test with keyboard
  • A11y check: Does this new spinner affect a11y at all? If so how? How to mitigate?
  • All other CTA buttons (besides Agency Index home page button) should have height 60px

image

image

@machikoyasuda machikoyasuda self-assigned this Oct 12, 2022
@machikoyasuda machikoyasuda added this to the Courtesy Cards milestone Oct 12, 2022
@github-actions github-actions bot added deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates labels Oct 12, 2022
@machikoyasuda machikoyasuda marked this pull request as ready for review October 13, 2022 18:37
@machikoyasuda machikoyasuda requested a review from a team as a code owner October 13, 2022 18:37
Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thekaveman
Copy link
Member

Wait why only for reCAPTCHA?

@machikoyasuda
Copy link
Member Author

Wait why only for reCAPTCHA?

Oops that's false actually. I added the spinner divs to both branches of the code so it'll show up without reCaptcha too.

@machikoyasuda
Copy link
Member Author

Shelving this for the time being until #1068 bug is resolved.

@thekaveman
Copy link
Member

@machikoyasuda did you want someone to grab this one now that #1068 is merged?

@machikoyasuda
Copy link
Member Author

@thekaveman yeah I was planning to - but you can do this ticket too! Whichever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button: Add animation to the Check/Checking button
3 participants