Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reCAPTCHA is bypassing HTML5 form validation #1068

Closed
thekaveman opened this issue Oct 13, 2022 · 0 comments · Fixed by #1071
Closed

reCAPTCHA is bypassing HTML5 form validation #1068

thekaveman opened this issue Oct 13, 2022 · 0 comments · Fixed by #1071
Assignees
@thekaveman
Labels
bug Something isn't working security Changes to improve or maintain the availability and resilience of the app
Milestone
Courtesy Cards

Comments

@thekaveman
Copy link
Member

reCAPTCHA is allowing the form to submit even when required fields are not provided:

no-field-validation

This SO post from 2017 talks about the same issue: https://stackoverflow.com/questions/41665935/html5-form-validation-before-recaptchas

To Reproduce

Steps to reproduce the behavior:

  1. Go to dev
  2. Don't choose any Verifier and submit the form - see no form validation
  3. Choose Courtesy Cards
  4. Do not enter any CC#/Name and submit the form - see no form validation

Expected behavior

The browser's default HTML5 field validation for e.g. required fields should kick in and not allow the form to be submitted with invalid fields.
@thekaveman thekaveman added the bug Something isn't working label Oct 13, 2022
@angela-tran angela-tran added this to the Courtesy Cards milestone Oct 14, 2022
@machikoyasuda machikoyasuda mentioned this issue Oct 14, 2022
Closed
@thekaveman thekaveman self-assigned this Oct 14, 2022
@thekaveman thekaveman moved this to In Progress in Digital Services Oct 14, 2022
@thekaveman thekaveman added the security Changes to improve or maintain the availability and resilience of the app label Oct 14, 2022
@thekaveman thekaveman mentioned this issue Oct 14, 2022
Merged
Repository owner moved this from In Progress to Done in Digital Services Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thekaveman thekaveman

Labels
bug Something isn't working security Changes to improve or maintain the availability and resilience of the app
Projects
Digital Services
Archived in project
Milestone
Courtesy Cards
Development

Successfully merging a pull request may close this issue.

Fix: reCAPTCHA + HTML5 form validation cal-itp/benefits
2 participants
@thekaveman @angela-tran